Re: [PATCH v4 4/4] leds: lm3532: Introduce the lm3532 LED driver

[Lee Jones]

On Wed, 20 Mar 2019, Dan Murphy wrote:
> On 3/20/19 1:59 PM, Jacek Anaszewski wrote:
> > On 3/13/19 1:32 PM, Dan Murphy wrote:
> >> Introduce the Texas Instruments LM3532 White LED driver.
> >> The driver supports ALS configurability or manual brightness
> >> control.
> >>
> >> The driver also supports associating LED strings with specific
> >> control banks in a group or as individually controlled strings.
> >>
> >> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> >> ---
> >>
> >> v4 - Updated code to DT doc changes appending "ti," to TI specific properties -
> >> https://lore.kernel.org/patchwork/patch/1050124/
> >>
> >> v3 - Removed switch case for register setting in favor of an algorithim (v1 comment),
> >> https://lore.kernel.org/patchwork/patch/1049024/
> >> v2 - Added look up tables for als_avg, als_imp and ramp times, fixed brightness
> >> control when ALS is in control, added property value checks to ensure the values
> >> are not out of bounds - https://lore.kernel.org/patchwork/patch/1048807/
> >>
> >> Â drivers/leds/KconfigÂÂÂÂÂÂ |Â 10 +
> >> Â drivers/leds/MakefileÂÂÂÂÂ |ÂÂ 1 +
> >> Â drivers/leds/leds-lm3532.c | 681 +++++++++++++++++++++++++++++++++++++
> >> Â 3 files changed, 692 insertions(+)
> >> Â create mode 100644 drivers/leds/leds-lm3532.c

[snip 700 lines of churn]

> Ack.  I give post v5 tomorrow.

Same for you too please Dan.

-- 
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog