Re: [PATCH RFC 01/14] arm64/mm: Introduce asid_info structure and move asid_generation/asid_map to it

[Julien Grall]

On 3/21/19 5:03 PM, Suzuki K Poulose wrote:
> Hi Julien,

Hi Suzuki,

> On 21/03/2019 16:36, Julien Grall wrote:
> > In an attempt to make the ASID allocator generic, create a new structure
> > asid_info to store all the information necessary for the allocator.
> >
> > For now, move the variables asid_generation and asid_map to the new 
> > structure
> > asid_info. Follow-up patches will move more variables.
> >
> > Note to avoid more renaming aftwards, a local variable 'info' has been
> > created and is a pointer to the ASID allocator structure.
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> > ---
> > Â arch/arm64/mm/context.c | 46 
> > ++++++++++++++++++++++++++--------------------
> > Â 1 file changed, 26 insertions(+), 20 deletions(-)
> >
> > diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c
> > index 1f0ea2facf24..34db54f1a39a 100644
> > --- a/arch/arm64/mm/context.c
> > +++ b/arch/arm64/mm/context.c
> > @@ -30,8 +30,11 @@
> > Â static u32 asid_bits;
> > Â static DEFINE_RAW_SPINLOCK(cpu_asid_lock);
> > -static atomic64_t asid_generation;
> > -static unsigned long *asid_map;
> > +struct asid_info
> > +{
> > +ÂÂÂ atomic64_tÂÂÂ generation;
> > +ÂÂÂ unsigned longÂÂÂ *map;
> > +} asid_info;
>
> Shouldn't this be static ? Rest looks fine.

Yes it should be static. I have updated my code.

Thank you for the review!

Cheers,

> Cheers
> Suzuki

--
Julien Grall