RE: [Intel-wired-lan] [PATCH net] ixgbe: fix mdio bus registration

From: Bowers, AndrewX
Date: Thu Mar 21 2019 - 18:32:52 EST


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@xxxxxxxxxx] On
> Behalf Of Ivan Vecera
> Sent: Friday, March 15, 2019 1:45 AM
> To: netdev@xxxxxxxxxxxxxxx
> Cc: open list <linux-kernel@xxxxxxxxxxxxxxx>; moderated list:INTEL
> ETHERNET DRIVERS <intel-wired-lan@xxxxxxxxxxxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>
> Subject: [Intel-wired-lan] [PATCH net] ixgbe: fix mdio bus registration
>
> The ixgbe ignores errors returned from mdiobus_register() and leaves
> adapter->mii_bus non-NULL and MDIO bus state as MDIOBUS_ALLOCATED.
> This triggers a BUG from mdiobus_unregister() during ixgbe_remove() call.
>
> Fixes: 8fa10ef01260 ("ixgbe: register a mdiobus")
> Signed-off-by: Ivan Vecera <ivecera@xxxxxxxxxx>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@xxxxxxxxx>