Re: Re: [PATCH V2 2/2] Input: rotaty-encoder - Add DT binding document

[Alexey Slepov]

Hello,

i used this rotary-encoder patch in my embedded project and found two 
errors:


First, in drivers/input/misc/rotary_encoder.c,
at @@ -237,6 +244,16 @@:
instead of

+ÂÂÂÂÂÂÂ if (err)
+ÂÂÂÂÂÂÂÂÂÂÂ dev_err(dev, "unable to get keycodes: %d\n", err);
+ÂÂÂÂÂÂÂ return err;

it must be

+ÂÂÂÂÂÂÂ if (err) {
+ÂÂÂÂÂÂÂÂÂÂÂ dev_err(dev, "unable to get keycodes: %d\n", err);
+ÂÂÂÂÂÂÂÂÂÂÂ return err;
+ÂÂÂÂÂÂÂ }

otherwise successful creation of device is not possible.


Second, a typo in 
Documentation/devicetree/bindings/input/rotary-encoder.txt,
at @@ -48,3 +52,11 @@:
instead of

+ÂÂÂÂÂÂÂÂÂÂÂ rotary-encoder,relative-keycode = <103>, <108>;

it should be

+ÂÂÂÂÂÂÂÂÂÂÂ rotary-encoder,relative-keycodes = <103>, <108>;

otherwise keycodes are not found.


I am sorry, I know that E-Mail style is not good.
I have no time right now, but I'll be back in two weeks.
Someone, maybe Mr. Han, could submit a new version of the patch.
If not, I'll try to do it on my return. (it could take some time, since 
I am new to patchwork)

Best Regards and thanks
Alexey Slepov