Re: [RESEND PATCH v6 04/11] dt-bindings: input: add DT bindings for max77650

[Bartosz Golaszewski]

pt., 22 mar 2019 o 10:09 Pavel Machek <pavel@xxxxxx> napisaÅ(a):
>
> On Mon 2019-03-18 18:42:21, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> >
> > Add the DT binding document for the onkey module of max77650.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>
> > +     onkey {
> > +             compatible = "maxim,max77650-onkey";
> > +             linux,code = <KEY_END>;
> > +             maxim,onkey-slide;
> > +     };
>
> This is certainly wrong.
>
> "End" key is normal key on a keyboard, certainly not some kind of
> slider.
>
> And this controller is likely to be used for power key, not end key,
> right?

But this is just an example of available properties, not a real use-case.

Bart

>
>                                                                         Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html