Re: [PATCH] usb: typec: tcpm: collision avoidance

[Kyle Tso]

On Fri, Mar 22, 2019 at 12:51 AM Kyle Tso <kyletso@xxxxxxxxxx> wrote:
>
> On Wed, Mar 20, 2019 at 1:38 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> >

> > >  static enum tcpm_state tcpm_default_state(struct tcpm_port *port)
> > >  {
> > >       if (port->port_type == TYPEC_PORT_DRP) {
> > > @@ -600,6 +664,9 @@ static void tcpm_debugfs_exit(const struct tcpm_port *port) { }
> > >
> > >  #endif
> > >
> > > +static int tcpm_ams_start(struct tcpm_port *port, enum tcpm_ams ams,
> > > +                       bool start);
> > > +
> >
> > Does this have to be a forward declaration ?
> >
> tcpm_pd_transmit() calls tcpm_ams_start() and tcpm_ams_start() calls
> tcpm_pd_transmit()
>
Since tcpm_ams_start will be divided into two parts, tcpm_pd_transmit no
longer needs to call tcpm_ams_start.

I will remove the forward declaration in the next version.

thanks,
Kyle