Re: [PATCH 11/12] ARM: OMAP2+: add missing of_node_put after of_device_is_available
From: Tony Lindgren
Date: Fri Mar 22 2019 - 18:25:00 EST
* Julia Lawall <Julia.Lawall@xxxxxxx> [190223 13:58]:
> Add an of_node_put when a tested device node is not available.
>
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> identifier f;
> local idexpression e;
> expression x;
> @@
>
> e = f(...);
> ... when != of_node_put(e)
> when != x = e
> when != e = x
> when any
> if (<+...of_device_is_available(e)...+>) {
> ... when != of_node_put(e)
> (
> return e;
> |
> + of_node_put(e);
> return ...;
> )
> }
> // </smpl>
>
> Fixes: e0c827aca0730 ("drm/omap: Populate DSS children in omapdss driver")
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
Thanks applying this one into omap-for-v5.1/fixes.
Regards,
Tony