Re: [PATCH v4 07/11] tracing: Remove trigger-extended-error-support testcase

[Masami Hiramatsu]

Hi Tom,

This should be tagged with "selftests/ftrace:". :)

Thank you,

On Fri, 22 Mar 2019 10:34:33 -0500
Tom Zanussi <zanussi@xxxxxxxxxx> wrote:

> From: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx>
> 
> Error handling has been moved to the common tracing/error_log, so this
> test is no longer valid.
> 
> Signed-off-by: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx>
> ---
>  .../inter-event/trigger-extended-error-support.tc  | 28 ----------------------
>  1 file changed, 28 deletions(-)
>  delete mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-extended-error-support.tc
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-extended-error-support.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-extended-error-support.tc
> deleted file mode 100644
> index 9912616a8672..000000000000
> --- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-extended-error-support.tc
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -#!/bin/sh
> -# SPDX-License-Identifier: GPL-2.0
> -# description: event trigger - test extended error support
> -
> -
> -fail() { #msg
> -    echo $1
> -    exit_fail
> -}
> -
> -if [ ! -f set_event ]; then
> -    echo "event tracing is not supported"
> -    exit_unsupported
> -fi
> -
> -if [ ! -f synthetic_events ]; then
> -    echo "synthetic event is not supported"
> -    exit_unsupported
> -fi
> -
> -echo "Test extended error support"
> -echo 'hist:keys=pid:ts0=common_timestamp.usecs if comm=="ping"' > events/sched/sched_wakeup/trigger
> -! echo 'hist:keys=pid:ts0=common_timestamp.usecs if comm=="ping"' >> events/sched/sched_wakeup/trigger 2> /dev/null
> -if ! grep -q "ERROR:" events/sched/sched_wakeup/hist; then
> -    fail "Failed to generate extended error in histogram"
> -fi
> -
> -exit 0
> -- 
> 2.14.1
> 


-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>