Re: [PATCH v0] nvmem: core: Export nvmem cell info to userspace

[Gaurav Kohli]

On 3/22/2019 8:53 PM, Srinivas Kandagatla wrote:
> On 20/03/2019 05:53, Gaurav Kohli wrote:
> > From: Shiraz Hashim <shashim@xxxxxxxxxxxxxx>
> >
> > Existing nvmem framework export full register space
> > as nvmem binary, but not exporting child node of nvmem
> > which is nvmem cell. Kernel can read the specific cell
> > by using nvmem_cell_read but userspace don't have such
> > provision.
> >
> > Add framework to export nvmem cell as well, So
> > userspace can use it directly.
> >
> > Signed-off-by: Shiraz Hashim <shashim@xxxxxxxxxxxxxx>
> > Signed-off-by: Gaurav Kohli <gkohli@xxxxxxxxxxxxxx>
> > Co-developed-by: Gaurav Kohli <gkohli@xxxxxxxxxxxxxx>
> >
> > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
>
> Thankyou for the patch.
>
> Why do you need such provision when the userspace can just get the 
> cell values using correct offset and size.
> This will also bring over head of managing entries dynamically + 
> confusing userspace abi.
>
> Unless you have a valid reason or usecase I don't see the need for this.


Hi Srinivas,


This is mainly for user space convenience, In existing implementation 
they have to do manipulation according

to offset and bit, And with present patch, they just have to do cat for 
cell name and which can also be easily maintainable

for different soc. But with current, it is difficult to maintain users 
space code as each time we have to change user space code according to bit.


This would also help to expose certain bit only as per the bit parameter 
mentioned in dt node, which would also help to protect exposing of

other bits to user space.

> thanks,
> srini

--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.