Re: [PATCH v2 1/5] staging: iio: adc: Tab alignment

[Cristian Sicilia]

On Sun, Mar 24, 2019 at 12:35:52PM +0000, Jonathan Cameron wrote:
> On Sat, 23 Mar 2019 20:21:36 +0100
> Cristian Sicilia <sicilia.cristian@xxxxxxxxx> wrote:
>
> > Aligned some parameters.
> >
> > Signed-off-by: Cristian Sicilia <sicilia.cristian@xxxxxxxxx>
> > ---
> >  drivers/staging/iio/adc/ad7280a.c | 36 ++++++++++++++++++------------------
> >  1 file changed, 18 insertions(+), 18 deletions(-)
> >
> > diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> > index d9df126..55b5879 100644
> > --- a/drivers/staging/iio/adc/ad7280a.c
> > +++ b/drivers/staging/iio/adc/ad7280a.c
> > @@ -830,30 +830,30 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
> >  }
> >
> >  static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> > -           in_voltage-voltage_thresh_low_value,
> > -           0644,
> > -           ad7280_read_channel_config,
> > -           ad7280_write_channel_config,
> > -           AD7280A_CELL_UNDERVOLTAGE);
> > +                        in_voltage - voltage_thresh_low_value,
> Firstly, that isn't in your description and secondly you just
> broke the userspace ABI.  Take a very good look at what is happening here.

Yes sorry, it will badly stringify, I fix it


>
> > +                        0644,
> > +                        ad7280_read_channel_config,
> > +                        ad7280_write_channel_config,
> > +                        AD7280A_CELL_UNDERVOLTAGE);
> >
> >  static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
> > -           in_voltage-voltage_thresh_high_value,
> > -           0644,
> > -           ad7280_read_channel_config,
> > -           ad7280_write_channel_config,
> > -           AD7280A_CELL_OVERVOLTAGE);
> > +                        in_voltage - voltage_thresh_high_value,
> > +                        0644,
> > +                        ad7280_read_channel_config,
> > +                        ad7280_write_channel_config,
> > +                        AD7280A_CELL_OVERVOLTAGE);
> >
> >  static IIO_DEVICE_ATTR(in_temp_thresh_low_value,
> > -           0644,
> > -           ad7280_read_channel_config,
> > -           ad7280_write_channel_config,
> > -           AD7280A_AUX_ADC_UNDERVOLTAGE);
> > +                  0644,
> > +                  ad7280_read_channel_config,
> > +                  ad7280_write_channel_config,
> > +                  AD7280A_AUX_ADC_UNDERVOLTAGE);
> >
> >  static IIO_DEVICE_ATTR(in_temp_thresh_high_value,
> > -           0644,
> > -           ad7280_read_channel_config,
> > -           ad7280_write_channel_config,
> > -           AD7280A_AUX_ADC_OVERVOLTAGE);
> > +                  0644,
> > +                  ad7280_read_channel_config,
> > +                  ad7280_write_channel_config,
> > +                  AD7280A_AUX_ADC_OVERVOLTAGE);
> >
> >  static struct attribute *ad7280_event_attributes[] = {
> >     &iio_dev_attr_in_thresh_low_value.dev_attr.attr,
>