Re: [PATCH] net: dccp: Checksum verification considering skb->ip_summed

From: David Miller
Date: Sun Mar 24 2019 - 20:14:00 EST


From: <Markus.Amend@xxxxxxxxxx>
Date: Fri, 22 Mar 2019 14:34:58 +0000

> @@ -786,7 +787,8 @@ static int dccp_v4_rcv(struct sk_buff *skb)
>
> iph = ip_hdr(skb);
> /* Step 1: If header checksum is incorrect, drop packet and return */
> - if (dccp_v4_csum_finish(skb, iph->saddr, iph->daddr)) {
> + if (__skb_checksum_validate(skb, IPPROTO_DCCP,
> + true, false, 0, inet_compute_pseudo)) {

The arguments on the second and subsequent lines of a function call must
begin precisely at the first column after the openning parenthesis of
the first line of the function call.

You must use the appropriate number of TAB, then SPACE, characters
necessary to achieve this.