Re: [PATCH] RISC-V: Always compile mm/init.c with cmodel=medany

From: Anup Patel
Date: Sun Mar 24 2019 - 23:20:04 EST


On Sun, Mar 24, 2019 at 8:27 PM Christoph Hellwig <hch@xxxxxx> wrote:
>
> On Sun, Mar 24, 2019 at 11:08:29AM +0000, Anup Patel wrote:
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> > Signed-off-by: Mike Rapoport <rppt@xxxxxxxxxxxxx>
>
> Huh? I don't think this is from Mike and me.
>
> > +unsigned long va_pa_offset;
> > +EXPORT_SYMBOL(va_pa_offset);
> > +unsigned long pfn_base;
> > +EXPORT_SYMBOL(pfn_base);
>
> Can you move va_pa_offset and pfn_base next to the swapper_pg_dir
> declaration? Thats where I move them in my current nommu patchset,
> as that allows to just have a single CONFIG_NOMMU in mm/init.c.
>
> Otherwise this looks fine to me.

Sure, no problem. I will send update and send v2.

Regards,
Anup