Re: [PATCH v2 0/2] clk: meson8b: add the video decoder clocks

From: Jerome Brunet
Date: Mon Mar 25 2019 - 06:02:06 EST


On Sun, 2019-03-24 at 16:14 +0100, Martin Blumenstingl wrote:
> This adds the video decoder clocks for Meson8, Meson8b and Meson8m2.
>
> The clock tree on Meson8 differs from the one one Meson8b and Meson8m2.
> Details can be found in patch #2.
>
> There are some checkpatch warnings in patch #2:
> WARNING: please, no space before tabs
> I decided to still send the patch because we have the same inconsistency
> with all other clk_hw_onecell_data table entries. Please let me know if
> I should come up with a follow-up patch to clean them all up.

A cleanup patch is always appreciated :) Before or after your changes, I don't
really mind. Up to you.

Acked-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>

>
> Testing:
> I have not tested this with Maxime's video decoder driver yet.
> However, I manually enabled and set various frequencies for the HCODEC
> clock and verified that clkmsr reports the correct rate.
>
> Dependencies:
> This is meant to be applied on top of my other series from [0]:
> clk: meson8b: add the VPU clock tree
>
> Changes since v1 at [1]:
> - collected Neil's and Maxime's Reviewed-by (thank you!)
>
>
> [0] https://patchwork.kernel.org/cover/10860401/
> [1] https://patchwork.kernel.org/cover/10860513/
>
>
> Martin Blumenstingl (2):
> dt-bindings: clock: meson8b: export the video decoder clocks
> clk: meson: meson8b: add the video decoder clock trees
>
> drivers/clk/meson/meson8b.c | 312 +++++++++++++++++++++++
> drivers/clk/meson/meson8b.h | 17 +-
> include/dt-bindings/clock/meson8b-clkc.h | 4 +
> 3 files changed, 332 insertions(+), 1 deletion(-)
>