Re: [PATCH] Documentation: acpi: Add an example for PRP0001

From: Thomas Preston
Date: Mon Mar 25 2019 - 10:42:15 EST


Hi,
Thanks for looking at this.

On 25/03/2019 13:04, Andy Shevchenko wrote:
On Mon, Mar 25, 2019 at 01:51:18PM +0200, Andy Shevchenko wrote:
On Mon, Mar 25, 2019 at 10:31:13AM +0100, Rafael J. Wysocki wrote:
On Fri, Mar 22, 2019 at 2:47 PM Thomas Preston
<thomas.preston@xxxxxxxxxxxxxxx> wrote:

Add an example for the magic PRP0001 device ID which allows matching
ACPI devices against drivers using OF Device Tree compatible property.
It wasn't clear to me that PRP0001 could be used in _CID.

Mika, Andy, can you have a look at this, please?

Good to me,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Though one thing I would like to add (not directly related to the patch
per se), i.e. it would be nice to keep such examples under meta-acpi [1]
umbrella as a database for such excerpts.

Thomas, can you do that?

[1]: https://github.com/westeri/meta-acpi

I will :)


+ Name (_HID, "TITMP75") /* _HID will appear in sysfs */

Sorry for not noticing earlier.

Is this an official ID for the chip? We discourage people to invent ACPI IDs on
their own.



The device is a TI tmp75b temperature sensor [0]. The HID is completely
made up, I'm afraid. It doesn't exist in the registry.

[0] http://www.ti.com/lit/ds/symlink/tmp75b.pdf