Re: [PATCH v3 4/4] RISC-V: Allow booting kernel from any 4KB aligned address

From: Christoph Hellwig
Date: Mon Mar 25 2019 - 10:55:54 EST


On Mon, Mar 25, 2019 at 06:12:28PM +0530, Anup Patel wrote:
> It uses new code for 2M mappings as well.

That seems to be an odd view - yes some code is shared, but we still
have two different ways using ifdefs.

> The code is lot better, readable and flexible.

better is in the eye of the beholder. It very much is not easier
readable with the spurious indirect calls at least. And it is a lot
bigger.