Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver

From: Dan Murphy
Date: Mon Mar 25 2019 - 12:01:58 EST


On 3/25/19 9:54 AM, Tony Lindgren wrote:
> * Dan Murphy <dmurphy@xxxxxx> [190325 12:36]:
>> On 3/22/19 5:16 PM, Tony Lindgren wrote:
>>> I can control the backlight brightness just fine via /sys, and
>>> backlight shows up as the trigger in /sys/class/leds/lm3532:backlight,
>>> but /sys/class/backlight is empty and looks like drm can't find it.
>>>
>>> Do I need to enable some additional driver(s) to get this to work
>>> with the drm driver?
>>>
>>
>> Can you dump or point to the defconfig?
>
> This is just with the omap2plus_defconfig as in the droid4-pending-v5.0
> test branch below [0]. That branch has Sebastian's drm patches. The
> branch also has the older ti-lmu patches that I reverted for testing
> before applying your new series and enabling it in .config.
>
> The drm driver (drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c) just
> does:
>
> backlight = of_parse_phandle(node, "backlight", 0);
> ...
>
> That should still work the same, right?

Yes it should still work the same.
I did not change the node name.
So the DRM driver should find the node.

Dan

>
> Regards,
>
> Tony
>
>
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/log/?h=droid4-pending-v5.0
>


--
------------------
Dan Murphy