Re: dell_smbios KASAN bug

From: Tom Zanussi
Date: Mon Mar 25 2019 - 12:20:57 EST


Hi Steve,

On Mon, 2019-03-25 at 10:17 -0400, Steven Rostedt wrote:
> On Mon, 25 Mar 2019 13:22:35 +0000
> <Mario.Limonciello@xxxxxxxx> wrote:
>
> > > diff --git a/drivers/platform/x86/dell-smbios-base.c
> > > b/drivers/platform/x86/dell-
> > > smbios-base.c
> > > index 9dc282ed5a9e..c3825c674522 100644
> > > --- a/drivers/platform/x86/dell-smbios-base.c
> > > +++ b/drivers/platform/x86/dell-smbios-base.c
> > > @@ -619,6 +619,7 @@ static int __init dell_smbios_init(void)
> > >
> > > fail_platform_driver:
> > > kfree(da_tokens);
> > > + da_num_tokens = 0;
> > > return ret;
> > > }
> > >
> >
> > Steven,
> >
> > Since Tom confirmed this works will you send a formal patch to the
> > ML with this fix?
>
> Will do.
>
> Tom,
>
> Is it OK if I add the following tags to that patch?
>
> Reported-by: Tom Zanussi <tzanussi@xxxxxxxxx>
> Tested-by: Tom Zanussi <tzanussi@xxxxxxxxx>
>

Yep, fine with me.

Tom

> -- Steve