Re: [PATCH v3] RISC-V: Always compile mm/init.c with cmodel=medany and notrace
From: Anup Patel
Date: Mon Mar 25 2019 - 23:58:08 EST
On Mon, Mar 25, 2019 at 5:08 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> > +ifdef CONFIG_FTRACE
> > +CFLAGS_REMOVE_init.o = -pg
> > +endif
> > +
> > obj-y += init.o
> > obj-y += fault.o
> > obj-y += extable.o
> > obj-y += ioremap.o
> > obj-y += cacheflush.o
> > +
> > +CFLAGS_init.o := -mcmodel=medany
>
> Can you keep the two flags adjustments togther, preferably towards
> the top of the file?
Sure, I will more the flags together.
>
> > +/*
> > + * The setup_vm() is called from head.S with MMU-off.
>
> s/The //g
Okay, I will update.
>
> Otherwis looks fine:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Regards,
Anup