Re: [PATCH] Change in comment for the list_empty() routine.

[Rasmus Villemoes]

On 26/03/2019 07.21, Nitin U. Yewale wrote:
> Hello,
> 
> In one of the observations it was noticed that list_empty() routine
> returns true when the list is empty (head->next == head) OR False
> otherwise. Hence the proposed patch.

Hm, does anything use that file? It's almost impossible to have a
translation unit that doesn't end up including linux/types.h since
struct list_head is embedded in so many other structs. So if the
nvif/list.h was also included by anything, I'd expect an immediate build
failure (error: redefinition of âstruct list_headâ). Also, nothing under
drivers/gpu does a #include of a list.h file that is not linux/list.h.

IOW, I suggest deleting drivers/gpu/drm/nouveau/include/nvif/list.h
entirely.

Rasmus