Re: [PATCH v6] tty: 8250: fix a missing check for pci_ioremap_bar

[Jiri Slaby]

On 26. 03. 19, 11:17, Andy Shevchenko wrote:
>> @@ -199,7 +203,10 @@ static void qrk_serial_exit_dma(struct lpss8250 *lpss)
>>  
>>  	if (!param->dma_dev)
>>  		return;
>> +
>>  	dw_dma_remove(&lpss->dma_chip);
>> +
>> +	iounmap(&lpss->dma_chip->regs);
> 
> This is a bit fragile form of writing. Perhaps

It actually won't even compile, will it (it must have been
"(&lpss->dma_chip)->regs")? Do you at least compile-test your patches
before sending?

thanks,
-- 
js
suse labs