Re: [PATCH v2 2/2] media:st-mipid02: MIPID02 CSI-2 to PARALLEL bridge driver

[Mickael GUENE]

Hi Sakari,

On 3/26/19 12:34, Sakari Ailus wrote:
> Hi Mickael,
> 
> On Mon, Mar 25, 2019 at 12:22:17PM +0000, Mickael GUENE wrote:
> ...
>>>> +	/* register it for later use */
>>>> +	bridge->rx = ep;
>>>> +	bridge->rx.link_frequencies = ep.nr_of_link_frequencies == 1 ?
>>>> +		&bridge->link_frequency : NULL;
>>>
>>> I think you need to simply ignore the link frequencies here. The
>>> transmitting device can tell the frequency based on its configuration
>>> (based on the link frequencies). You seem to have implemented that already.
>>>
>>  Idea of this was to allow some support for sensor that doesn't implement
>> V4L2_CID_PIXEL_RATE. Do you think it's useless ?
> 
> Sensor drivers need to be amended with support for that control.
> 
 Ok. I will drop mipid02_get_link_freq_from_rx_ep and mipid02_get_link_freq_from_cid_link_freq
and only use V4L2_CID_PIXEL_RATE to compute link speed.