Re: [PATCH v11 6/8] rtc: bd70528: Initial support for ROHM bd70528 RTC

[Alexandre Belloni]

On 26/03/2019 13:51:40+0000, Vaittinen, Matti wrote:
> On Mon, 2019-03-25 at 18:04 +0100, Alexandre Belloni wrote:
> > On 25/03/2019 14:06:42+0200, Matti Vaittinen wrote:
> > > Support RTC block in ROHM bd70528 power management IC. Support
> > > getting and setting the time and date as well as arming an alarm
> > > which can also be used to wake the PMIC from standby state.
> > > 
> > > HW supports wake interrupt only for the next 24 hours (sec, minute
> > > and hour information only) so we limit also the alarm interrupt to
> > > this 24 hours for the sake of consistency.
> > > 
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> > 
> > Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> > 
> > > +	r->time.hour |= BD70528_MASK_RTC_HOUR_24H;
> > > +	r->day |= bin2bcd(t->tm_mday);
> > > +	r->week |= bin2bcd(t->tm_wday);
> > > +	r->month |= bin2bcd(t->tm_mon + 1);
> > > +	r->year = bin2bcd(t->tm_year-100);
> > 
> > If you ever have to resend, please add spaces around that -
> 
> Good catch, thanks! I wonder why I didn't get checkpatch warning... I
> should've had one. (I usually do run checkpatch).
> 

checkpatch --strict would tell you.


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com