Re: [PATCH v2] x86/syscalls: Mark expected switch fall-throughs

[Thomas Gleixner]

On Tue, 26 Mar 2019, Steven Rostedt wrote:

> On Tue, 26 Mar 2019 17:09:44 +0100 (CET)
> Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> 
> > > >  1) The third argument of get/set(), i.e. the argument offset, is 0 on all
> > > >     call sites. Do we need it at all?  
> > > 
> > > Probably "maxargs" can be removed too, Steven sent the patches a long ago, see
> > > https://lore.kernel.org/lkml/20161107212634.529267342@xxxxxxxxxxx/  
> > 
> > Indeed. We should resurrect them.
> > 
> > > >  2) syscall_set_arguments() has been introduced in 2008 and we still have
> > > >     no caller. Instead of polishing it, can it be removed completely or are
> > > >     there plans to actually use it?  
> > > 
> > > I think it can die.  
> > 
> > Good. Removed code is the least buggy code :)
> > 
> > Gustavo, it would be really appreciated if you could take care of that,
> > unless Steven wants to polish his old set up himself. If you have no
> > cycles, please let us know.
> 
> I still have those patches in my quilt queue. I can polish them up and
> resend.

Appreciated.