Re: [PATCH v2] net: fjes: fix potential NULL pointer dereferences
From: David Miller
Date: Tue Mar 26 2019 - 13:50:55 EST
From: Kangjie Lu <kjlu@xxxxxxx>
Date: Fri, 22 Mar 2019 22:52:21 -0500
> @@ -1252,8 +1252,16 @@ static int fjes_probe(struct platform_device *plat_dev)
> adapter->open_guard = false;
>
> adapter->txrx_wq = alloc_workqueue(DRV_NAME "/txrx", WQ_MEM_RECLAIM, 0);
> + if (!adapter->txrx_wq) {
> + err = -ENOMEM;
> + goto err_free_netdev;
> + }
These error paths have to undo the netif_napi_add() done by fjes_sw_init().