Re: [PATCH 2/8] tools/lib/traceevent: Add counter to track parsing failures

From: Steven Rostedt
Date: Tue Mar 26 2019 - 15:48:52 EST


On Tue, 26 Mar 2019 17:43:22 +0200
Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx> wrote:

> This patch adds a parsing failures counter to struct tep_handle. The counter can
> be used to track failures on parsing event format files. It is updated
> automatically by tep_parse_event(), when failure is detected. The patch also
> adds two new APIs for accessing the counter:
> tep_get_parsing_failures() - returns the current value of the counter.
> tep_clear_parsing_failures() - clears the counter.
>

I think we can do the same thing here as we did test_filters.

I don't think we really need to put this into the tep interface. Let's
see if we can move this into trace-cmd itself and have it just keep
track of when parsing failed.

I mean, trace-cmd is just using the tep structure as place to store
this variable.

-- Steve