Re: [PATCH v2 6/6] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

From: Joe Perches
Date: Tue Mar 26 2019 - 16:18:15 EST


On Tue, 2019-03-26 at 14:41 +0200, Sakari Ailus wrote:
> Add support for %pfw conversion specifier (with "f" and "P" modifiers) to
> support printing full path of the node, including its name ("f") and only
> the node's name ("P") in the printk family of functions. The two flags
> have equivalent functionality to existing %pOF with the same two modifiers
> ("f" and "P") on OF based systems. The ability to do the same on ACPI
> based systems is added by this patch.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -5977,7 +5977,8 @@ sub process {
> while ($fmt =~ /(\%[\*\d\.]*p(\w))/g) {
> $specifier = $1;
> $extension = $2;
> - if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOx]/) {
> + if ($extension !~ /[SsBKRraEhMmIiUDdgVCbGNOxf]/ ||
> + $extension =~ /f[^w]/) {
> $bad_specifier = $specifier;
> last;
> }

You also need to remove the bit about using %pF or %pf below this

if ($bad_specifier =~ /p[Ff]/) {
$ext_type = "Deprecated";
$use = " - use %pS instead";
$use =~ s/pS/ps/ if ($bad_specifier =~ /pf/);
}