Re: [PATCH V3 2/5] mmc: mmci: define get_dctrl_cfg for legacy variant

[Ludovic BARRE]

On 3/26/19 6:46 PM, Ulf Hansson wrote:
> On Tue, 26 Mar 2019 at 10:11, Ludovic Barre <ludovic.Barre@xxxxxx> wrote:
> > From: Ludovic Barre <ludovic.barre@xxxxxx>
> >
> > This patch defines get_dctrl_cfg callback for legacy variants
> > whatever DMA_ENGINE configuration.
> >
> > Signed-off-by: Ludovic Barre <ludovic.barre@xxxxxx>
> > ---
> >   drivers/mmc/host/mmci.c | 31 +++++++++++++++++++++++--------
> >   drivers/mmc/host/mmci.h |  3 +++
> >   2 files changed, 26 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
> > index 9e6a2c1..4041e36 100644
> > --- a/drivers/mmc/host/mmci.c
> > +++ b/drivers/mmc/host/mmci.c
> > @@ -46,12 +46,6 @@
> >
> >   #define DRIVER_NAME "mmci-pl18x"
> >
> > -#ifdef CONFIG_DMA_ENGINE
> > -static void mmci_variant_init(struct mmci_host *host);
> > -#else
> > -static inline void mmci_variant_init(struct mmci_host *host) {}
> > -#endif
>
> Looks like you are moving the declaration to the header file. I would
> rather keep it here as there is no point in sharing to another c-file
> (at least not yet). The same applies for the new ux500v2 init
> function.

no problem, I will resend a V4 to keep mmci and ux500v2 variant init in 
the c file.

> Other than that, this looks good to me!

thanks

> Kind regards
> Uffe