Re: [PATCH -next v1] x86/apic: Reduce print level of CPU limit announcement

From: Joe Perches
Date: Wed Mar 27 2019 - 05:17:47 EST


On Wed, 2019-03-27 at 11:09 +0200, Leon Romanovsky wrote:
> Kernel is booted with less possible CPUs (possible_cpus kernel boot
> option) than available CPUs will have prints like this:
[]
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
[]
> @@ -2305,9 +2305,9 @@ int generic_processor_info(int apicid, int version)
> if (num_processors >= nr_cpu_ids) {
> int thiscpu = max + disabled_cpus;
>
> - pr_warning("APIC: NR_CPUS/possible_cpus limit of %i "
> - "reached. Processor %d/0x%x ignored.\n",
> - max, thiscpu, apicid);
> + pr_debug(
> + "APIC: NR_CPUS/possible_cpus limit of %i reached. Processor %d/0x%x ignored.\n",
> + max, thiscpu, apicid);

2 lines please

pr_debug("APIC: etc...",
max, thiscpu, ...);

And this would probably be better as

printk(KERN_DEBUG "APIC: etc...",
...)

to avoid the need to compile with DEBUG or enable
with CONFIG_DYNAMIC_DEBUG