Re: [PATCH] serial: Add Milbeaut serial control

[Sugaya, Taichi]

Hi

Thank you for your comments.

On 2019/03/26 18:57, Arnd Bergmann wrote:
> On Tue, Mar 26, 2019 at 10:13 AM Sugaya Taichi
> <sugaya.taichi@xxxxxxxxxxxxx> wrote:
>
> > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > index 72966bc..961519b 100644
> > --- a/drivers/tty/serial/Kconfig
> > +++ b/drivers/tty/serial/Kconfig
> > @@ -1582,6 +1582,32 @@ config SERIAL_RDA_CONSOLE
> >            Say 'Y' here if you wish to use the RDA8810PL UART as the system
> >            console. Only earlycon is implemented currently.
> >
> > +config SERIAL_MILBEAUT_USIO
> > +       tristate "Milbeaut USIO/UART serial port support"
> > +       depends on ARCH_MILBEAUT
> > +       default y
> > +       select SERIAL_CORE
> > +       help
> > +         This selects the USIO/UART IP found in Socionext Milbeaut SoCs.
>
> In general, it would be good to make it possible to build this on
> other architectures for better compile test coverage, e.g. like
>
> config SERIAL_MILBEAUT_USIO
>       tristate "Milbeaut USIO/UART serial port support"
>       depends on ARCH_MILBEAUT || COMPILE_TEST
>       default ARCH_MILBEAUT
All right.
I agree with the style.

> You might need additional dependencies like 'depends on OF'
> to make this work reliably.
I got it.
I think the way is inserting "depends on OF" as a new line.

Thanks,
Sugaya Taichi


>          Arnd