Re: [PATCH v2 1/9] soc: qcom: rpmpd: fixup rpmpd set performance state

[Sibi Sankar]

On 2019-03-25 09:33, Rajendra Nayak wrote:
> On 3/24/2019 11:19 PM, Sibi Sankar wrote:
> > Fixup rpmpd state to max if the required state is greater than all the
> > supported states.
>
> This should also say why, 'so the clients which just want to vote on 
> whatever
> is the max state supported can do so by passing an INT_MAX'?

will add more detail in v3

> > Fixes: 075d3db8d10d ("Add support for the .set_performace_state() and
> > .opp_to_performance_state()")
> >
> > Signed-off-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx>
> > ---
> >   drivers/soc/qcom/rpmpd.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c
> > index 005326050c23..235d01870dd8 100644
> > --- a/drivers/soc/qcom/rpmpd.c
> > +++ b/drivers/soc/qcom/rpmpd.c
> > @@ -226,7 +226,7 @@ static int rpmpd_set_performance(struct 
> > generic_pm_domain *domain,
> >   	struct rpmpd *pd = domain_to_rpmpd(domain);
> >     	if (state > MAX_RPMPD_STATE)
> > -		goto out;
> > +		state = MAX_RPMPD_STATE;
> >     	mutex_lock(&rpmpd_lock);

--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.