Re: [PATCH] RISC-V: Implement ASID allocator

[Gary Guo]

I think my code already get all the caveats cases covered. The only 
thing my code is missing is handling the case when ASID is not 
supported. Maybe it is better to work based on that instead?

On 27/03/2019 14:02, Anup Patel wrote:
> On Wed, Mar 27, 2019 at 7:12 PM Gary Guo <gary@xxxxxxxxxxx> wrote:
>>
>> I would also like to mention that your code assumes 64-bit atomics
>> support which we don't have on 32-bit systems. Using 32-bit to track
>> ASID generations isn't sufficient and will cause overflows. That's why I
>> have asid_generation_overflow to handle the case (this is super
>> error-prone as well).
> 
> Thanks for catching. I will fix issues with 32bit systems and send v2
> soon.
> 
> Regards,
> Anup
>