Re: [PATCH AUTOSEL 5.0 116/262] mwifiex: don't advertise IBSS features without FW support

[Brian Norris]

On Wed, Mar 27, 2019 at 11:05 AM Sasha Levin <sashal@xxxxxxxxxx> wrote:
>
> From: Brian Norris <briannorris@xxxxxxxxxxxx>
>
> [ Upstream commit 6f21ab30469d670de620f758330aca9f3433f693 ]
>
> As it is, doing something like
>
>   # iw phy phy0 interface add foobar type ibss
>
> on a firmware that doesn't have ad-hoc support just yields failures of
> HostCmd_CMD_SET_BSS_MODE, which happened to return a '-1' error code
> (-EPERM? not really right...) and sometimes may even crash the firmware
> along the way.
>
> Let's parse the firmware capability flag while registering the wiphy, so
> we don't allow attempting IBSS at all, and we get a proper -EOPNOTSUPP
> from nl80211 instead.
>
> Fixes: e267e71e68ae ("mwifiex: Disable adhoc feature based on firmware capability")
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

The backport seems valid and useful:

Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx>