Re: [PATCH v1 1/2] net: phy: mscc: add support for VSC8514 PHY

[David Miller]

From: <Kavyasree.Kotagiri@xxxxxxxxxxxxx>
Date: Wed, 27 Mar 2019 09:56:13 +0000

> +static u32 vsc85xx_csr_ctrl_phy_read(struct phy_device *phydev,
> +				     u32 target, u32 reg)
> +{
> +	u32 val, val_l, val_h;
> +	unsigned long deadline;

Please order local variable declarations from longest to shortest
line, ie. reverse christmas tree.

> +static int vsc8514_config_init(struct phy_device *phydev)
> +{
> +	int ret, i;
> +	u16 val, addr;
> +	u32 reg;
> +	unsigned long deadline;
> +	struct vsc8531_private *vsc8531 = phydev->priv;

Likewise.