Re: [PATCH 4/4] tests: add pidfd_open() tests
From: Christian Brauner
Date: Wed Mar 27 2019 - 16:55:44 EST
On Wed, Mar 27, 2019 at 12:36:46PM -0700, Kees Cook wrote:
> On Wed, Mar 27, 2019 at 9:22 AM Christian Brauner <christian@xxxxxxxxxx> wrote:
> >
> > This adds a simple test case for pidfd_open().
>
> Thank you for the tests. :) It might be nice to see more extensive
> negative testing -- making sure pids aren't reachable from mismatched
There'll be more tests for sure! Once people say that they are happy
with the design I can put in the effort to expand the tests to more
elaborate scenarios. :)
> pid namespaces, etc, but this gets us basic regression testing. Also,
> you might save some copy/paste code using kselftest_harness.h's
> interfaces.
>
> --
> Kees Cook