Re:Re: [PATCH] MIPS: KGDB: fix kgdb support for SMP platforms.

[qiaochong]

My name  is QiaoChongï which is same to my username.
Qiao is my family name.
Thanks a lot.

å 2019-03-28 00:25:06ï"Doug Anderson" <dianders@xxxxxxxxxxxx> åéï

>Hi,
>
>On Wed, Mar 27, 2019 at 8:06 AM qiaochong <qiaochong@xxxxxxxxxxx> wrote:
>>
>> KGDB_call_nmi_hook is called by other cpu through smp call.
>> MIPS smp call is processed in ipi irq handler and regs is saved in
>>  handle_int.
>> So kgdb_call_nmi_hook get regs by get_irq_regs and regs will be passed
>>  to kgdb_cpu_enter.
>>
>> Signed-off-by: qiaochong <qiaochong@xxxxxxxxxxx>
>
>Note that you might want to adjust your git settings.  Usually in the
>kernel they require that a Signed-off-by have your real name, not just
>your username.  You probably need to spin your patch to fix this.  You
>should make sure that the authorship of the patch also has your real
>name.
>
>
>> ---
>>  arch/mips/kernel/kgdb.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/kernel/kgdb.c b/arch/mips/kernel/kgdb.c
>> index 6e574c02e4c3b..ea781b29f7f17 100644
>> --- a/arch/mips/kernel/kgdb.c
>> +++ b/arch/mips/kernel/kgdb.c
>> @@ -33,6 +33,7 @@
>>  #include <asm/processor.h>
>>  #include <asm/sigcontext.h>
>>  #include <linux/uaccess.h>
>> +#include <asm/irq_regs.h>
>>
>>  static struct hard_trap_info {
>>         unsigned char tt;       /* Trap type code for MIPS R3xxx and R4xxx */
>> @@ -214,7 +215,7 @@ void kgdb_call_nmi_hook(void *ignored)
>>         old_fs = get_fs();
>>         set_fs(KERNEL_DS);
>>
>> -       kgdb_nmicallback(raw_smp_processor_id(), NULL);
>> +       kgdb_nmicallback(raw_smp_processor_id(), get_irq_regs());
>>
>>         set_fs(old_fs);
>>  }
>
>As per my reply on V1, feel free to add:
>
>Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>


åäåææåäåæçäçæçèåéèääå2åæ 100095çè: +86 (10) 62546668äç: +86 (10) 62600826www.loongson.cnæéäååéäåæéèäçæææéååçåäçåäæïäéäåéçäéååäååçääæççãçæääåäääääååäçïåæääéäåéæé ååæéãååææåïæéäååéääçäæãåææéææéäïèæçåçèæéäéçåääååéæéäã 

This email and its attachments contain confidential information from Loongson
Technology Corporation Limited, which is intended only for the person or entity
whose address is listed above. Any use of the information contained herein in
any way (including, but not limited to, total or partial disclosure,
reproduction or dissemination) by persons other than the intended recipient(s)
is prohibited. If you receive this email in error, please notify the sender by
phone or email immediately and delete it.