Re: [PATCH net-next v5 16/22] ethtool: provide link settings and link modes in GET_SETTINGS request

[Florian Fainelli]

On 3/25/2019 10:08 AM, Michal Kubecek wrote:
> Implement GET_SETTINGS netlink request to get link settings and link mode
> information provided by ETHTOOL_GLINKSETTINGS ioctl command.
> 
> The information in SET_SETTINGS message sent as reply is divided into two
> parts: autonegotiation, speed, duplex and supported, advertised and peer
> advertised link modes when ETH_SETTINGS_IM_LINKMODES flag is set in the
> request and other settings when ETH_SETTINGS_IM_LINKINFO is set.
> 
> Send notification in the same format as the reply message when relevant
> fields are modified using the ioctl interface (ETHTOOL_SLINKSETTINGS or
> ETHTOOL_SSET command).
> 
> Signed-off-by: Michal Kubecek <mkubecek@xxxxxxx>
> ---

[snip]

> +    ETHA_SETTINGS_DEV		(nested)	device identification
> +    ETHA_SETTINGS_LINK_INFO	(nested)	link settings
> +        ETHA_LINKINFO_PORT		(u8)		physical port
> +        ETHA_LINKINFO_PHYADDR		(u8)		MDIO address of phy
> +        ETHA_LINKINFO_TP_MDIX		(u8)		MDI(-X) status
> +        ETHA_LINKINFO_TP_MDIX_CTRL	(u8)		MDI(-X) control
> +        ETHA_LINKINFO_TRANSCEIVER	(u8)		transceiver
> +    ETHA_SETTINGS_LINK_MODES	(nested)	link modes
> +        ETHA_LINKMODES_AUTONEG		(u8)		autoneotiation status

Typo: auto-negotiation status.
-- 
Florian