Re: [PATCH v2 3/7] x86/boot: Split out parse_serial_port() helper for earlyprintk

From: Borislav Petkov
Date: Thu Mar 28 2019 - 10:03:30 EST


On Thu, Mar 28, 2019 at 03:50:15PM +0200, Andy Shevchenko wrote:
> Can, but with code uglifying to workaround kstrtox() restrictions.
> simple_strtox() _just works_ as expected.

simple_strtox() also has its problems.

> Requires buffer copying, finding digits there, making a proper termination. And

It needs a single kstrtoull() call to parse the port. And we have
kstrtoull() available in the compressed stage so pls do the conversion
ontop.

Thx.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.