Re: [PATCH 0/2] KVM: SVM: move the SEV command handling into a separate file

[Singh, Brijesh]

Hi Paolo and Radim,


On 2/1/19 10:47 AM, Singh, Brijesh wrote:
> svm.c is pretty huge, before we add more SEV specific commands (e.g SEV-ES,
> SEV-Migration etc) lets move the SEV command handling into a separate file.
> There is no logical changes in this series.
> 

Any thoughts on this series ?


> The patch is based on motivation from this thread:
> https://marc.info/?l=linux-kernel&m=153910240507399&w=2
> 
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Cc: "Radim KrÄmÃÅ" <rkrcmar@xxxxxxxxxx>
> Cc: Joerg Roedel <joro@xxxxxxxxxx>
> Cc: Tom Lendacky <Thomas.Lendacky@xxxxxxx>
> 
> Brijesh Singh (2):
>    KVM: SVM: move common struct definitions to header file
>    KVM: SVM: move the SEV specific function in a separate file
> 
>   arch/x86/include/asm/svm.h |  155 +++++
>   arch/x86/kvm/Makefile      |    2 +
>   arch/x86/kvm/sev.c         | 1076 +++++++++++++++++++++++++++++++
>   arch/x86/kvm/sev.h         |   40 ++
>   arch/x86/kvm/svm.c         | 1234 +-----------------------------------
>   5 files changed, 1296 insertions(+), 1211 deletions(-)
>   create mode 100644 arch/x86/kvm/sev.c
>   create mode 100644 arch/x86/kvm/sev.h
> 


-Brijesh