Re: [PATCH v2 2/7] x86/boot: Introduce helpers for serial I/O

[Borislav Petkov]

On Thu, Mar 28, 2019 at 04:20:01PM +0200, Andy Shevchenko wrote:
> By name and by what it's handling (only byte accesses to I/O or MMIO).

Your series does only byte accesses so you can use byte variant.

> My point is, that doing branch(es) on each I/O call is not good as simple
> calling the proper (pre-defined) I/O accessor.

What branches?

You do a branch and *then* you do an IO call.

What does "not good" even mean?

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.