Re: [PATCH v2 1/2] bus: tegra-aconnect: use devm_clk_*() helpers
From: Thierry Reding
Date: Thu Mar 28 2019 - 12:32:54 EST
On Wed, Mar 13, 2019 at 10:11:58AM +0530, Sameer Pujar wrote:
> aconnect bus driver is using pm_clk_*() interface for managing clocks.
> With this, clocks seem to be always ON. This happens on Tegra devices
> which use BPMP co-processor to manage clock resources, where clocks
> are enabled during prepare phase. This is necessary because calls to
> BPMP are always blocking. When pm_clk_*() interface is used on such
> Tegra devices, clock prepare count is not balanced till driver remove()
> gets executed and hence clocks are seen ON always. Thus this patch
> replaces pm_clk_*() with devm_clk_*() framework.
>
> Suggested-by: Mohan Kumar D <mkumard@xxxxxxxxxx>
> Reviewed-by: Jonathan Hunter <jonathanh@xxxxxxxxxx>
> Signed-off-by: Sameer Pujar <spujar@xxxxxxxxxx>
> ---
> drivers/bus/tegra-aconnect.c | 64 ++++++++++++++++++++++++++++++--------------
> 1 file changed, 44 insertions(+), 20 deletions(-)
Both patches applied to for-5.2/bus, thanks.
Thierry
Attachment:
signature.asc
Description: PGP signature