Re: [PATCH v3 2/4] dt-bindings: maxbotix,mb1232: Add MaxBotix i2c ultrasonic rangers

[Rob Herring]

On Sun, Mar 17, 2019 at 09:35:27PM +0100, Andreas Klinger wrote:
> Add doc for dt binding maxbotix,mb1232. This binding is for MaxBotix
> I2CXL-MaxSonar ultrasonic rangers which share a common i2c interface.
> 
> Signed-off-by: Andreas Klinger <ak@xxxxxxxxxxxxx>
> ---
>  .../bindings/iio/proximity/maxbotix,mb1232.txt     | 31 ++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.txt b/Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.txt
> new file mode 100644
> index 000000000000..0e9df87eca1d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.txt
> @@ -0,0 +1,31 @@
> +* MaxBotix I2CXL-MaxSonar ultrasonic distance sensor of type  mb1202,
> +  mb1212, mb1222, mb1232, mb1242, mb7040 or mb7137 using the i2c interface
> +  for ranging
> +
> +Required properties:
> + - compatible:		"maxbotix,mb1202",
> +			"maxbotix,mb1212",
> +			"maxbotix,mb1222",
> +			"maxbotix,mb1232",
> +			"maxbotix,mb1242",
> +			"maxbotix,mb7040" or
> +			"maxbotix,mb7137"
> +
> + - reg:			i2c address of the device, see also i2c/i2c.txt
> +
> +Optional properties:
> + - interrupt-parent:	Interrupt controller to use

Don't need this as it is implied and could be in the parent.

Otherwise,

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

> +
> + - interrupts:		Interrupt used to announce the preceding reading
> +			request has finished and that data is available.
> +			If no interrupt is specified the device driver
> +			falls back to wait a fixed amount of time until
> +			data can be retrieved.
> +
> +Example:
> +proximity@70 {
> +	compatible = "maxbotix,mb1232";
> +	reg = <0x70>;
> +	interrupt-parent = <&gpio2>;
> +	interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
> +};
> -- 
> 2.11.0