Re: [PATCH] MIPS: SGI-IP27: Fix use of unchecked pointer in shutdown_bridge_irq

From: Paul Burton
Date: Thu Mar 28 2019 - 14:38:01 EST


Hello,

Thomas Bogendoerfer wrote:
> smatch complaint:
>
> arch/mips/sgi-ip27/ip27-irq.c:123 shutdown_bridge_irq()
> warn: variable dereferenced before check 'hd' (see line 121)
>
> Fix it by removing local variable and use hd->pin directly.
>
> Fixes: 69a07a41d908 ("MIPS: SGI-IP27: rework HUB interrupts")
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@xxxxxxx>
> Reviewed-by: Mukesh Ojha <mojha@xxxxxxxxxxxxxx>

Applied to mips-fixes.

Thanks,
Paul

[ This message was auto-generated; if you believe anything is incorrect
then please email paul.burton@xxxxxxxx to report it. ]