Re: [PATCH 1/4] arm64: dts: imx8mq: Fix the fsl,imx8mq-sdma compatible string

From: Daniel Baluta
Date: Fri Mar 29 2019 - 07:20:19 EST


On Fri, Mar 29, 2019 at 11:11 AM Aisheng Dong <aisheng.dong@xxxxxxx> wrote:
>
> > From: Angus Ainslie (Purism) [mailto:angus@xxxxxxxx]
> > Sent: Thursday, March 28, 2019 9:38 PM
> >
> > Fix a typo in the compatible string
> >
> > Signed-off-by: Angus Ainslie (Purism) <angus@xxxxxxxx>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index 81d5ce1b1ec1..07099f82965e 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -720,7 +720,7 @@
> > };
> >
> > sdma1: sdma@30bd0000 {
> > - compatible = "fsl, imx8mq-sdma","fsl,imx7d-sdma";
> > + compatible = "fsl,mx8mq-sdma","fsl,imx7d-sdma";
>
> This is a bit strange.
> If binding doc says like that, probably we'd better fix the typo in binding doc
> to use the same style.

Oh, indeed.

Angus, shouldn't this be fsl,imx8mq-sdma instead of fsl,mx8mq-sdma. I
was just paying
attention to the extra space in my patch.