Re: [PATCH] tick/broadcast: Fix warning about undefined tick_broadcast_oneshot_offline()

[Mukesh Ojha]

On 3/29/2019 4:35 PM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@xxxxxxx>
>
> Randconfig builds with
>
>    CONFIG_TICK_ONESHOT=y
>    CONFIG_HOTPLUG_CPU=n
>
> trigger
>
>    kernel/time/tick-broadcast.c:39:13: warning: âtick_broadcast_oneshot_offlineâ \
> 	  declared âstaticâ but never defined [-Wunused-function]
>
> due to that function's definition missing.
>
> Move the CONFIG_HOTPLUG_CPU ifdeffery around its declaration too.
>
> Fixes: 1b72d4323798 ("tick: Remove outgoing CPU from broadcast masks")
> Signed-off-by: Borislav Petkov <bp@xxxxxxx>
> Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Valentin Schneider <valentin.schneider@xxxxxxx>
> Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: x86@xxxxxxxxxx


Reviewed-by: Mukesh Ojha <mojha@xxxxxxxxxxxxxx>

Cheers,
-Mukesh

> ---
>   kernel/time/tick-broadcast.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
> index 0283523de045..7541cbca695e 100644
> --- a/kernel/time/tick-broadcast.c
> +++ b/kernel/time/tick-broadcast.c
> @@ -36,12 +36,16 @@ static __cacheline_aligned_in_smp DEFINE_RAW_SPINLOCK(tick_broadcast_lock);
>   static void tick_broadcast_setup_oneshot(struct clock_event_device *bc);
>   static void tick_broadcast_clear_oneshot(int cpu);
>   static void tick_resume_broadcast_oneshot(struct clock_event_device *bc);
> +# ifdef CONFIG_HOTPLUG_CPU
>   static void tick_broadcast_oneshot_offline(unsigned int cpu);
> +# endif
>   #else
>   static inline void tick_broadcast_setup_oneshot(struct clock_event_device *bc) { BUG(); }
>   static inline void tick_broadcast_clear_oneshot(int cpu) { }
>   static inline void tick_resume_broadcast_oneshot(struct clock_event_device *bc) { }
> +# ifdef CONFIG_HOTPLUG_CPU
>   static inline void tick_broadcast_oneshot_offline(unsigned int cpu) { }
> +# endif
>   #endif
>   
>   /*