Re: [PATCH 0/3] vmalloc enhancements

From: Roman Gushchin
Date: Fri Mar 29 2019 - 18:08:17 EST


On Mon, Feb 25, 2019 at 12:30:34PM -0800, Roman Gushchin wrote:
> The patchset contains few changes to the vmalloc code, which are
> leading to some performance gains and code simplification.
>
> Also, it exports a number of pages, used by vmalloc(),
> in /proc/meminfo.
>
> Patch (1) removes some redundancy on __vunmap().
> Patch (2) separates memory allocation and data initialization
> in alloc_vmap_area()
> Patch (3) adds vmalloc counter to /proc/meminfo.
>
> v3->v2:
> - switched back to atomic after more accurate perf measurements:
> no visible perf difference
> - added perf stacktraces in commmit message of (1)
>
> v2->v1:
> - rebased on top of current mm tree
> - switch from atomic to percpu vmalloc page counter
>
> RFC->v1:
> - removed bogus empty lines (suggested by Matthew Wilcox)
> - made nr_vmalloc_pages static (suggested by Matthew Wilcox)
> - dropped patch 3 from RFC patchset, will post later with
> some other changes
> - dropped RFC
>
> Roman Gushchin (3):
> mm: refactor __vunmap() to avoid duplicated call to find_vm_area()
> mm: separate memory allocation and actual work in alloc_vmap_area()
> mm: show number of vmalloc pages in /proc/meminfo
>
> fs/proc/meminfo.c | 2 +-
> include/linux/vmalloc.h | 2 +
> mm/vmalloc.c | 107 ++++++++++++++++++++++++++--------------
> 3 files changed, 73 insertions(+), 38 deletions(-)
>
> --
> 2.20.1
>

Ping. Any comments/suggestions/objections?

Thanks!