Re: [RFC PATCH 01/68] kbuild: skip sub-make for in-tree build with GNU Make 4.x
From: Masahiro Yamada
Date: Sat Mar 30 2019 - 08:13:33 EST
On Thu, Mar 28, 2019 at 9:53 AM Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
>
> David,
>
>
> On Thu, Mar 28, 2019 at 8:41 AM David Howells <dhowells@xxxxxxxxxx> wrote:
> >
> > From: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> >
> > Commit 2b50f7ab6368 ("kbuild: add workaround for Debian make-kpkg")
> > annoyed people who want to wrap the top Makefile with GNUmakefile
> > or something in order to customize it for their use.
> >
> > On second thought, we do not need to run the sub-make for in-tree
> > build with Make 4.x because the 'MAKEFLAGS += -rR' issue only happens
> > on GNU Make 3.x.
> >
> > With this commit, people will get back the workflow, and the Debian
> > make-kpkg will still work.
> >
> > Fixes: 2b50f7ab6368 ("kbuild: add workaround for Debian make-kpkg")
> > Reported-by: Andreas Schwab <schwab@xxxxxxx>
> > Reported-by: David Howells <dhowells@xxxxxxxxxx>
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> > Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
>
>
> Why should this patch be included in a
> totally unrelated patch series?
>
>
> I already applied this to my fixes branch,
> and am planning to send a PR to Linus soon.
>
> (Sorry, I missed to send a PR for -rc2)
Now, this landed in Linus tree.
--
Best Regards
Masahiro Yamada