Re: [PATCH 01/17] kbuild: Disable -Waddress-of-packed-member for gcc 9

[Masahiro Yamada]

Hi,

On Fri, Mar 22, 2019 at 10:59 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Thu, Mar 21, 2019 at 11:00 PM Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> >
> > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> >
> > This warning is very noisy in a default build with gcc 9.
> > Move it into W=2 only.
> >
> > Cc: arnd@xxxxxxxx
> > Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> > Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
> I think W=2 is too aggressive. On many architectures, this finds
> real bugs and the false positives tend to be trivial to fix
> (by removing the bogus __packed annotation), which improves
> the generated code in the process.
>
> Moving it to W=1 for the moment is probably fine, but ideally
> I think we should fix the kernel to behave according to the
> C standard.
>
>       Arnd



I agree to disable this warning option
since we see a lot of instances.

The room of argument is W=1 or W=2?
I do not have a strong opinion either way.

Arnd most actively takes care of warnings like this.
If he looks into these warnings, W=1 is fine with me.


-- 
Best Regards
Masahiro Yamada