Re: [PATCH 3/7] irqchip/al-msi: Rename AL-MSIx driver

[Marc Zyngier]

On Sun, 31 Mar 2019 13:34:11 +0100,
Hanna Hawa <hhhawa@xxxxxxxxxx> wrote:
> 
> Alpine is the name of the SoC family, while AL stands for Annapurna
> Labs. Rename to the latter since the driver will appear in other SoC
> families other than Alpine.
> 
> Add device tree match for "amazon/al-msix".
> 
> Signed-off-by: Hanna Hawa <hhhawa@xxxxxxxxxx>
> ---
>  arch/arm/mach-alpine/Kconfig                       |  2 +-
>  arch/arm64/Kconfig.platforms                       |  2 +-
>  drivers/irqchip/Kconfig                            |  2 +-
>  drivers/irqchip/Makefile                           |  2 +-
>  drivers/irqchip/{irq-alpine-msi.c => irq-al-msi.c} | 93 +++++++++++-----------
>  5 files changed, 49 insertions(+), 52 deletions(-)
>  rename drivers/irqchip/{irq-alpine-msi.c => irq-al-msi.c} (68%)

Why do we need this churn? It feels absolutely pointless. Adding your
new compatibility string is absolutely fine; repainting the whole
driver because you've found a "better" name for it isn't.

Thanks,

	M.

-- 
Jazz is not dead, it just smell funny.