Re: [PATCH v2] gcov: fix when CONFIG_MODULES is not set

From: Nick Desaulniers
Date: Mon Apr 01 2019 - 22:55:05 EST


On Sun, Mar 31, 2019 at 6:57 AM Tri Vo <trong@xxxxxxxxxxx> wrote:
>
> On Fri, Mar 29, 2019 at 1:53 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> >
> > On 3/29/19 11:18 AM, Nick Desaulniers wrote:
> > > Fixes commit 8c3d220cb6b5 ("gcov: clang support")
> >
> > There is a certain format for Fixes: and that's not quite it. :(

Looks like the format is:
Fixes: <first 12 characters of commit sha> ("<first line of commit>")
so:
Fixes: 8c3d220cb6b5 ("gcov: clang support")

We should update:
https://www.kernel.org/doc/html/v5.0/process/stable-kernel-rules.html
to include this information.

> Thanks for taking a look at this Nick! I believe same fix should be
> applied to kernel/gcov/clang.c. I'll send out an updated version later
> today.

All yours, happy to review.

--
Thanks,
~Nick Desaulniers