Re: [Letux-kernel] [BUG] gpiolib: spi chip select legacy support breaks modern chip select and whitens the GTA04 LCD panel

From: Linus Walleij
Date: Tue Apr 02 2019 - 00:18:56 EST

On Sun, Mar 31, 2019 at 1:33 AM Andreas Kemnade <andreas@xxxxxxxxxxxx> wrote:

> > > But I fixed it in that case by introducing a spi-cs-high into the DTS file:
> > >
> >
> > Yes, that of course works and is our temporary solution.
> >
> > And I see that you also have it on the controller node and not the slave node.
> >
> So if I get it right is a check added for undocumented properties
> (nothing about spi-cs-high in controller node in the bindings
> documentation, only in the slave node) in the two patches mentioned.
> And then you add that undocumented property to a dts file in your "fix".
> That all sounds strange to me.

Yeah it sounds strange because it is strange :)

I was simply confused and wrong. Sometimes we all do very uniformed
things, today it was me.

The flag should of course be on the slave node.

So now I have to fix my fix.

Linus Walleij